@yenda, no, not a fork. I created a module that uses react-navigation
- GitHub - vkjr/react-native-navigation-twopane
And I used documentation from react-navigation 3, so we should be good, I believe basic API is the same
@hester, I also noticed that welcome screen doesnāt look correct in landscape mode. So yeah, image settings should be checked. It is not related to two-pane UI itself, I believe.
yes itās not relative , they are developed only for mobile, so they resize full screen with fixed margins in px
great progress!
also, love to see so much interest in this topic
What would be required to set relative margins? (and would this fix it?)
Progress update:
- returned from vacation.
- added switching between one-pane and two-pane UIs depending on device screen size
- basic 2-pane UI implementation can be found in this PR - https://github.com/status-im/status-react/pull/8444
Problems:
Code from PR worked fine with react-navigation
v2, but after status-react moved to react-navigation
v3 one glitch appeared - every time user switches between chats whole screen re-renders 2 times. So PR is still WIP
and Iām looking into this issue.
Progress update:
After a bunch of fixes 2-pane ui for mobile platforms finally merged!
So now it is time to make mobile ui the default one for desktop platforms.
great work guys. Looking forward to using the new desktop ui.
@volodymyr.kozieiev could you confirm that if we remove realm it will be much easier to remove the ubuntu-server? Iām making a plan to remove realm WIP Removing realm - CodiMD
@andrey, correct, these are next steps:
- run 2-pane mobile UI on desktop,
- make mobile UI default for desktop,
- remove old desktop UI
Right now working on the first one .
Current issue:
We already have flag in .env
file that enables mobile ui for desktop. But since it was last checked mobile ui switched to react-navigation v3
. And newer navigation depends on react-native-gesture-handler
library that provides native (ios and android) ways to deal with gestures. It looks like we need to support this library on desktop to reuse latest mobile UI :-/
what project is this?
Progress update:
react-native-gesture-handler
mock created
After this few problems revealed that fixed in `react-native-desktop:
- Added implementation of
pointerEvents
property of View - Fixed internal events propagation.
Now 2-pane mobile UI works fine with desktop. PR with test builds created. It needs full testing to find all small issues before merging to develop
.
So far known issues are:
- Text input in chat gains focus only when clicked in the leftmost part of area.
- Window that opens after click on āshare my profileā has broken layout
Working on them.
Volodymyr youāre a one man army, incredible work man!
Progress update:
- Fixed issue with text input focus and not always working āsendā button in chat.
- Started work on implementing shadows in
react-native-desktop
View component. It is crucial for design.
Bunch of issues were collected for mobile UI desktop builds. Most of them are desirable UI improvements but some should be implemented on react-native-desktop
side, like shadows mentioned above.
Note: Iām on a long vacation till 2nd September, so will continue when return.
Quick update:
I returned from vacation and continue 2-pane UI. A lot of changes were made in develop during these 3 weeks, so fixes needed to make 2-pane PR work again. So far desktop compiling was fixed in develop
branch and added missed functions in react-native-status
. Now working on problem with logging in on desktop.
Any recent updates about this?